[hail] Publicize and document Table.multi_way_zip_join #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It remains experimental.
chrisvittal
force-pushed
the
stablize-mwzj
branch
from
49f2094
to
ab6f91a
Compare
chrisvittal
commented
Jun 27, 2019
| @@ -3212,7 +3212,40 @@ def _unlocalize_entries(self, entries_field_name, cols_field_name, col_key) -> ' | |||
|
|
|||
| @staticmethod | |||
| @typecheck(tables=sequenceof(table_type), data_field_name=str, global_field_name=str) | |||
| def _multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table': | |||
| def multi_way_zip_join(tables, data_field_name, global_field_name) -> 'Table': | |||
There was a problem hiding this comment.
I don't believe the behaviour of this will change in a backwards incompatible way. The only stabilization question that I think is unresolved is do we want these parameters to have default values?
There was a problem hiding this comment.
Adding a default value is backwards compatible, so we can punt on that for now. But I also don't see any problem with just picking something reasonable like "row_fields" and "global_fields". I'm fine with either option, and ready to approve once you decide.
There was a problem hiding this comment.
leave them off for now then.
patrick-schultz
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It remains experimental.